<html>
<head><meta charset="utf-8"><title>when making reviews ... · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/when.20making.20reviews.20.2E.2E.2E.html">when making reviews ...</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="200228453"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/when%20making%20reviews%20.../near/200228453" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/when.20making.20reviews.20.2E.2E.2E.html#200228453">(Jun 09 2020 at 13:41)</a>:</h4>
<p>wanted to note this that we've just merged <a href="https://forge.rust-lang.org/compiler/reviews.html#high-priority-issues">https://forge.rust-lang.org/compiler/reviews.html#high-priority-issues</a></p>



<a name="200228550"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/when%20making%20reviews%20.../near/200228550" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/when.20making.20reviews.20.2E.2E.2E.html#200228550">(Jun 09 2020 at 13:41)</a>:</h4>
<p>when merging PRs that close high priority issues do <code>@bors r+ rollup=never p=1</code></p>



<a name="200286625"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/when%20making%20reviews%20.../near/200286625" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/when.20making.20reviews.20.2E.2E.2E.html#200286625">(Jun 09 2020 at 20:36)</a>:</h4>
<p>It's unlikely that people will do this without automation.</p>



<a name="200286776"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/when%20making%20reviews%20.../near/200286776" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/when.20making.20reviews.20.2E.2E.2E.html#200286776">(Jun 09 2020 at 20:37)</a>:</h4>
<p>But at the same time automation for this seems hard to me</p>



<a name="200287578"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/when%20making%20reviews%20.../near/200287578" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/when.20making.20reviews.20.2E.2E.2E.html#200287578">(Jun 09 2020 at 20:43)</a>:</h4>
<p>It seems like bors could just look at the github pr tags... if it is P-critical or P-high, bors automatically issues a comment to himself with <code>@bors rollup=never p=1</code></p>



<a name="200287606"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/when%20making%20reviews%20.../near/200287606" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/when.20making.20reviews.20.2E.2E.2E.html#200287606">(Jun 09 2020 at 20:43)</a>:</h4>
<p>Alternately, I bet that highfive bot could do this too</p>



<a name="200288032"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/when%20making%20reviews%20.../near/200288032" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/when.20making.20reviews.20.2E.2E.2E.html#200288032">(Jun 09 2020 at 20:47)</a>:</h4>
<p>Is there a way to get linked issues out of a PR? If so it's easy</p>



<a name="200288169"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/when%20making%20reviews%20.../near/200288169" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/when.20making.20reviews.20.2E.2E.2E.html#200288169">(Jun 09 2020 at 20:48)</a>:</h4>
<p>And there might be since the client GUI displays them in a list</p>



<a name="200421428"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/when%20making%20reviews%20.../near/200421428" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/when.20making.20reviews.20.2E.2E.2E.html#200421428">(Jun 10 2020 at 14:15)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span> to automate this</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>